[ARTEMIS-1629] Set clientID on STOMP connections before authentication

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.5.0
• Component/s: STOMP

Environment

Artemis 2.5.0-SNAPSHOT

• Assignee: Justin Bertram
• Reporter: Johan Stenberg
• Created: 23/Jan/18 09:03
• Updated: 05/Apr/18 23:11
• Resolved: 23/Jan/18 22:38

Description

We are using a custom security manager in our setup. Opposite to other protocols (e.g. AMQP), executing remotingConnection.getClientID() returns null for StompConnections when accessed from within ActiveMQSecurityManager3#validateUser(String, String, RemotingConnection).

We however already need to know the client at this time as we perform certain validations/on-the-fly configurations based on the value.

The issue would be solved if the statement connection.setClientID(clientID); from https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v10/StompFrameHandlerV10.java#L56 would be moved two lines up before if (connection.validateUser(login, passcode, connection)) {

 

Issue Links

• links to: GitHub Pull Request #1806