Uploaded image for project: 'ActiveMQ Artemis'
  1. ActiveMQ Artemis
  2. ARTEMIS-1626

Disable thread leak check for failing tests

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.4.0
    • 2.5.0
    • Broker
    • None

    Description

      The ThreadLeakCheckRule is used to check thread leaks

      after each test is finished. However when a test fails, it is

      not necessary to check leaking threads because the test

      failure should be fixed anyway. And leaking threads in a

      failed test may well be a result of the failure (once the test

      is fixed the thread leak may be gone).

      If a failed test also leaks threads, it takes a long time before

      the thread leak check finishes (60 seconds checking time),

      thus it takes a long time to finish, especially when tests are

      run in batches with failures.

      So to improve this, it should be reasonable to just enable

      the thread leaking check for each test passes, and disable

      the check when a test fails.

      Attachments

        Issue Links

          Activity

            People

              gaohoward Howard Gao
              gaohoward Howard Gao
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: