[ARTEMIS-1395] FindBugs: Dubious method used: System.exit() in CoreMessage#toString()

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.4.0
• Component/s: Broker

Environment

commit 53a9c9b47b8c64ff2c0f2c6be40a1cf5984e5e8b (HEAD -> master, upstream/master)
Merge: 49ef04b6f d2dcf1bba
Author: Clebert Suconic <[e-mail]>
Date: Wed Sep 6 10:30:13 2017 -0400

This closes #1513

• External issue URL: https://scan7.coverity.com/reports.htm#v10043/p14213/fileInstanceId=33820779&defectInstanceId=7427745&mergedDefectId=1455427
• External issue ID: 1455427
• Assignee: Timothy A. Bish
• Reporter: Jiri Daněk
• Created: 06/Sep/17 18:13
• Updated: 09/Sep/17 18:55
• Resolved: 09/Sep/17 18:55

Description

This is weird. Possibly some left over debugging code. I never saw this actually crash Artemis, though. Still, I think it should be changed.

1079   @Override
1080   public String toString() {
1081      try {
1082         checkProperties();
1083         return "CoreMessage[messageID=" + messageID + ",durable=" + isDurable() + ",userID=" + getUserID() + ",priority=" + this.getPriority()  +
1084            ", timestamp=" + toDate(getTimestamp()) + ",expiration=" + toDate(getExpiration()) +
1085            ", durable=" + durable + ", address=" + getAddress() + ",properties=" + properties + "]@" + System.identityHashCode(this);
1086      } catch (Throwable e) {
1087         e.printStackTrace();
    	
CID 1455427 (#1 of 1): Dm: Dubious method used (FB.DM_EXIT)
1. defect: org.apache.activemq.artemis.core.message.impl.CoreMessage.toString() invokes System.exit(...), which shuts down the entire virtual machine.
1088         System.exit(-1);
1089         return "ServerMessage[messageID=" + messageID + "]";
1090      }
1091   }

Issue Links

• is part of: ARTEMIS-1400 FindBugs warnings
• links to: GitHub Pull Request #1525