[ARTEMIS-1190] Long/int type mismatch in JDBCSequentialFile.setWritePosition

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.5, 2.1.0
• Fix Version/s: 2.2.0
• Component/s: Broker
• Assignee: Unassigned
• Reporter: Erich Duda
• Created: 30/May/17 10:20
• Updated: 03/Aug/21 13:33
• Resolved: 26/Feb/18 17:03

Description

In the JDBCSequentialFile.setWritePosition there is mismatch between types. The parameter of the method has type int but the private field has type long.

private long writePosition = 0;

void setWritePosition(int writePosition) {
   this.writePosition = writePosition;
}

Because of this in JDBCSequentialFileFactoryDriver.loadFile the long is unnecessarily retype to int.

public void loadFile(JDBCSequentialFile file) throws SQLException {
    synchronized (connection) {
       connection.setAutoCommit(false);
       readLargeObject.setLong(1, file.getId());

       try (ResultSet rs = readLargeObject.executeQuery()) {
          if (rs.next()) {
             Blob blob = rs.getBlob(1);
             if (blob != null) {
                file.setWritePosition((int) blob.length());
             } else {
                logger.warn("ERROR NO BLOB FOR FILE" + "File: " + file.getFileName() + " " + file.getId());
             }
          }
          connection.commit();
       } catch (SQLException e) {
          connection.rollback();
          throw e;
       }
    }
}

Issue Links

• links to: GitHub Pull Request #1302
• links to: GitHub Pull Request #1306