[ARROW-952] Compilation error on macOS with clang-802.0.42

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4.0
• Component/s: C++

Environment

g++ --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/c++/4.2.1
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

uname -a
Darwin XXX.berkeley.edu 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64

• External issue URL: https://github.com/apache/arrow/issues/16551
• Assignee: Philipp Moritz
• Reporter: Philipp Moritz
• Created: 05/May/17 20:37
• Updated: 11/Jan/23 07:11
• Resolved: 05/May/17 23:42

Description

Compiling commit 2c3e111d45c056d429cef312533c9f3f96b08ae8 of arrow with Apple LLVM version 8.1.0 gives the following error:

```
In file included from /Users/istoica/src/ray/minicamp-may5-17/ray-1/src/numbuf/thirdparty/arrow/cpp/src/arrow/python/helpers.cc:20:
In file included from /Users/istoica/src/ray/minicamp-may5-17/ray-1/src/numbuf/thirdparty/arrow/cpp/src/arrow/util/decimal.h:24:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/regex:1216:29: error:
too many arguments provided to function-like macro invocation
_ct->tolower(&_s[0], &_s[0] + __s.size());
^
/Users/istoica/anaconda/include/python2.7/pyport.h:729:9: note: macro 'tolower'
defined here
#define tolower(c) towlower(btowc(c))
^
In file included from /Users/istoica/src/ray/minicamp-may5-17/ray-1/src/numbuf/thirdparty/arrow/cpp/src/arrow/python/helpers.cc:20:
In file included from /Users/istoica/src/ray/minicamp-may5-17/ray-1/src/numbuf/thirdparty/arrow/cpp/src/arrow/util/decimal.h:24:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/regex:1228:29: error:
too many arguments provided to function-like macro invocation
_ct->tolower(&_s[0], &_s[0] + __s.size());
^
/Users/istoica/anaconda/include/python2.7/pyport.h:729:9: note: macro 'tolower'
defined here
#define tolower(c) towlower(btowc(c))
^
In file included from /Users/istoica/src/ray/minicamp-may5-17/ray-1/src/numbuf/thirdparty/arrow/cpp/src/arrow/python/builtin_convert.cc:30:
```

It is a similar problem to
https://github.com/apache/arrow/commit/4d2ac871c9126ba431ebb193ea19bd5eb7ef8ab3