[ARROW-9500] [C++] Fix segfault with std::to_string in -O3 builds on gcc 7.5.0

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/25569
• Assignee: Wes McKinney
• Reporter: Wes McKinney
• Created: 16/Jul/20 03:04
• Updated: 11/Jan/23 08:07
• Resolved: 16/Jul/20 04:58

Description

There seems to be a gcc bug related to std::to_string that only appears in -O3 builds. It can be seen in something innocuous like

    return Status::Invalid("Float value ", std::to_string(val), " was truncated converting to",
                           *output.type());

where val is NaN. I haven't found a canonical reference but using something other than to_string for the formatting (here just letting std::ostringstream take care of it) makes the problem go away

I wasn't able to reproduce the issue with gcc-8

EDIT: it's a known bug in gcc https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86274

Issue Links

• links to: GitHub Pull Request #7781