Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-9492

[C++] Ensure private functions are static or in an anonymous namespace

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 0.17.1
    • None
    • C++
    • None

    Description

      There are a number of functions which are not intended to be exported (for example, they are defined in a .cc file) but are not marked static inline or declared in an anoymous namespace. This can lead to surprising link errors. Existing private functions should be marked appropriately, and ideally a linter could be assembled to ensure new ones are not added without appropriate markings.

      Attachments

        Activity

          People

            Unassigned Unassigned
            bkietz Ben Kietzman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: