Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-9188

[C++] Do not always statically link Brotli libraries

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0
    • C++

    Description

      I discovered by symbol sleuthing that even if the Brotli shared libraries are available on the system, the static libraries will be used for linking. Here's a dump of the symbols on my machine

      https://gist.github.com/wesm/b7e911424ce3ca3a175b652666fe6f89

      The largest of these symbols kBrotliDictionaryData is 120KB

      Since we statically link everything in our Python wheels, we might consider disabling Brotli in manylinux builds at least since it adds 800KB to libarrow.so

      Attachments

        Issue Links

          Activity

            People

              wesm Wes McKinney
              wesm Wes McKinney
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 20m
                  3h 20m