[ARROW-8974] [C++] Refine TransferBitmap template parameters

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/17208
• Assignee: Yibo Cai
• Reporter: Yibo Cai
• Created: 28/May/20 03:03
• Updated: 11/Jan/23 08:03
• Resolved: 10/Jun/20 11:00

Description

TransferBitmap has two template parameters of bool type with four combinations.
Change them to function parameters can reduce code size. I think "restore_trailing_bits" cannot impact performance. "invert_bits" needs benchmark.
Also, bool parameter is hard to figure out at caller side, better to use meaningful defines.

Issue Links

• is related to: ARROW-8970 [C++] Reduce shared library / binary code size (umbrella issue)
• links to: GitHub Pull Request #7373