[ARROW-8924] [C++][Gandiva] castDATE_date32() may cause overflow

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: C++ - Gandiva
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/25054
• Assignee: Kazuaki Ishizaki
• Reporter: Kazuaki Ishizaki
• Created: 24/May/20 17:15
• Updated: 11/Jan/23 08:03
• Resolved: 24/May/20 20:38

Description

The following code in `cpp/src/gandiva/precompiled/time.cc` may cause overflow since `int32` * `int32` is `int32`, then it is converted to `int64`. The result of `int32` may loose the part of the result of the multiplication

 

gdv_date64 castDATE_date32(gdv_date32 days) { return days * MILLIS_IN_DAY; } 

Issue Links

• links to: GitHub Pull Request #7260