Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-8661

[C++][Gandiva] Reduce number of files and headers

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • C++, C++ - Gandiva
    • None

    Description

      I feel that the Gandiva subpackage is more Java-like in its code organization than the rest of the Arrow codebase, and it might be easier to navigate and develop with closely related code condensed into some larger headers and compilation units. At present there are over 100 .h/.cc files in just src/gandiva, not considering subdirectories

      Additionally, it's not necessary to have a header file for each component of the function registry – the registration functions can be declared in function_registry.h or function_registry_internal.h

      Attachments

        Activity

          People

            Unassigned Unassigned
            wesm Wes McKinney
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: