[ARROW-8160] [FlightRPC][C++] DoPutPayloadWriter doesn't always expose server error message

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.16.0
• Component/s: C++, FlightRPC
• External issue URL: https://github.com/apache/arrow/issues/24363
• Assignee: Unassigned
• Reporter: David Li
• Created: 19/Mar/20 12:47
• Updated: 11/Jan/23 07:58

Description

C:/projects/arrow/cpp/src/arrow/flight/flight_test.cc(1261): error: Value of: status.message()
Expected: has substring "Invalid token"
  Actual: "Could not write record batch to stream: "
[  FAILED  ] TestBasicAuthHandler.FailUnauthenticatedCalls (17 ms)

This happens because Close() calls RecordBatchPayloadWriter::Close(), which calls CheckStarted, which in turn tries to write data. If the data gets flushed and the server responds in time, we'll see a failure during writing, causing us to never check the server status (which is the last part of DoPutPayloadWriter::Close). We need to reliably check and expose the gRPC status.