[ARROW-7881] [C++] Fix pedantic warnings

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.17.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/24106
• Assignee: Neal Richardson
• Reporter: Neal Richardson
• Created: 18/Feb/20 23:36
• Updated: 11/Jan/23 07:56
• Resolved: 19/Feb/20 09:35

Description

Saw this while working on ARROW-7880:

In file included from /arrow/r/libarrow/arrow-0.16.0.9000/include/arrow/compute/kernel.h:27,
                 from /arrow/r/libarrow/arrow-0.16.0.9000/include/arrow/compute/api.h:22,
                 from ./arrow_types.h:199,
                 from chunkedarray.cpp:18:
/arrow/r/libarrow/arrow-0.16.0.9000/include/arrow/scalar.h:399:2: warning: extra ‘;’ [-Wpedantic]
 };  // namespace internal
  ^
In file included from /arrow/r/libarrow/arrow-0.16.0.9000/include/arrow/compute/api.h:31,
                 from ./arrow_types.h:199,
                 from chunkedarray.cpp:18:
/arrow/r/libarrow/arrow-0.16.0.9000/include/arrow/compute/kernels/mean.h:66:2: warning: extra ‘;’ [-Wpedantic]
 };  // namespace arrow
  ^
In file included from /arrow/r/libarrow/arrow-0.16.0.9000/include/arrow/dataset/file_base.h:29,
                 from /arrow/r/libarrow/arrow-0.16.0.9000/include/arrow/dataset/api.h:22,
                 from ./arrow_types.h:201,
                 from chunkedarray.cpp:18:
/arrow/r/libarrow/arrow-0.16.0.9000/include/arrow/dataset/scanner.h:40:2: warning: extra ‘;’ [-Wpedantic]
 };
  ^
In file included from /arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/encryption.h:28,
                 from /arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/properties.h:29,
                 from /arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/metadata.h:29,
                 from /arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/file_reader.h:26,
                 from /arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/arrow/reader.h:25,
                 from ./arrow_types.h:217,
                 from chunkedarray.cpp:18:
/arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/schema.h:319:36: warning: extra ‘;’ [-Wpedantic]
 PRIMITIVE_FACTORY(Boolean, BOOLEAN);
                                    ^
/arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/schema.h:320:32: warning: extra ‘;’ [-Wpedantic]
 PRIMITIVE_FACTORY(Int32, INT32);
                                ^
/arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/schema.h:321:32: warning: extra ‘;’ [-Wpedantic]
 PRIMITIVE_FACTORY(Int64, INT64);
                                ^
/arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/schema.h:322:32: warning: extra ‘;’ [-Wpedantic]
 PRIMITIVE_FACTORY(Int96, INT96);
                                ^
/arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/schema.h:323:32: warning: extra ‘;’ [-Wpedantic]
 PRIMITIVE_FACTORY(Float, FLOAT);
                                ^
/arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/schema.h:324:34: warning: extra ‘;’ [-Wpedantic]
 PRIMITIVE_FACTORY(Double, DOUBLE);
                                  ^
/arrow/r/libarrow/arrow-0.16.0.9000/include/parquet/schema.h:325:41: warning: extra ‘;’ [-Wpedantic]
 PRIMITIVE_FACTORY(ByteArray, BYTE_ARRAY);

Issue Links

• links to: GitHub Pull Request #6451