Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-782

[C++] Change struct to class for objects that meet the criteria in the Google style guide

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.3.0
    • C++
    • None

    Description

      See https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes. I have suspected that the types in type.h should be classes, but this suggests it pretty strongly. It would be better to address this sooner rather than later.

      We should also make the member access functions instead of bare attributes, e.g. type->id() instead of type->type

      Attachments

        Issue Links

          Activity

            People

              wesm Wes McKinney
              wesm Wes McKinney
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: