Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-7411

[C++][Flight] Incorrect Arrow Flight benchmark output

    XMLWordPrintableJSON

    Details

      Description

      When running Arrow Flight benchmark in the following scenario, the output is incorrect.

      $ ./arrow-flight-perf-server &
      [1] 12986
      Server host: localhost
      Server port: 31337
      $ ./arrow-flight-benchmark -server_host localhost -test_put 
      Using remote server: true
      Testing method: DoPut
      Server host: localhost
      Server port: 31337
      Bytes read: 1280000000
      Nanos: 496372147
      Speed: 2459.25 MB/s
      

      Using remote server should be false and Bytes read should be Bytes write.

      To correct the result of Using remote server, we can:

      • Change if (FLAGS_server_host == "") to another condition which checks if there is already an arrow-flight-perf-server running. This is a bit complicated to do and might add some unnecessary complexity (e.g. we need to make sure it support all OSes.). 
      • Delete Using remote server, since we already have Server host in the output.

      I personally prefer the second option and will make a PR.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                cxma Chengxin Ma
                Reporter:
                cxma Chengxin Ma
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m