Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-7304

[C++] clang-tidy diagnostics not emitted for most headers

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.15.1
    • Fix Version/s: None
    • Component/s: C++, CI, Continuous Integration
    • Labels:
      None

      Description

      The HeaderFilterRegex in .clang-tidy is written

      HeaderFilterRegex: '^(.*codegen.*|.*_generated.*|.*windows_compatibility.h|.*pyarrow_api.h|.*pyarrow_lib.h|.*python/config.h|.*python/platform.h|.*thirdparty/ae/.*|.*vendored/.*|.*RcppExports.cpp.*|)$'
      

      as if it was an exclusion filter, but HeaderFilterRegex is in fact an inclusion mechanism. So clang-tidy diagnostics are not emitted for I guess most of the headers in Arrow.

      See https://github.com/apache/arrow/commit/72b553147e4bd47e100fbfd58ed49041561b7bc4#r36225046 which is where I came across this.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              estan Elvis Stansvik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: