Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-7289

[C#] ListType constructor argument is redundant

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.15.1
    • 0.16.0
    • C#

    Description

      https://github.com/apache/arrow/blob/master/csharp/src/Apache.Arrow/Types/ListType.cs#L28

       

      The ListType constructor has two arguments but 'ValueDataType' can be determined by 'Filed.DataType' and 'ValueFiled' can be created by valueDataType.

      It seems to me that the constructor should be separated to "ListType(Field valueField)" and " ListType(IArrowType valueDataType)".

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            HashidaTKS Takashi Hashida
            HashidaTKS Takashi Hashida
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 20m
                2h 20m

                Slack

                  Issue deployment