[ARROW-7206] [Java] Avoid string concatenation when calling Preconditions#checkArgument

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.16.0
• Component/s: Java
• Labels: patch pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/16969
• Assignee: stephane campinas
• Reporter: stephane campinas
• Created: 19/Nov/19 11:54
• Updated: 11/Jan/23 07:52
• Resolved: 19/Nov/19 14:11

Description

Preconditions#checkArgument is called in VectorLoader with the String message already built.

This causes some noticeable overhead as can be seen from the attached flame graphs.

 

Calling checkArgument with an error template instead avoids the call to StringBuilder as can be seen in the after image.

Issue Links

• links to: GitHub Pull Request #5863