[ARROW-7049] [C++] warnings building on mingw-w64

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.15.1
• Fix Version/s: 0.17.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/23359
• Assignee: Ben Kietzman
• Reporter: Jeroen
• Created: 02/Nov/19 14:59
• Updated: 11/Jan/23 07:51
• Resolved: 23/Mar/20 21:05

Description

Two warnings when building libarrow 0.15.1 on mingw-w64:

[  2%] Running thrift compiler on parquet.thrift
[WARNING:C:/msys64/home/mingw-packages/mingw-w64-arrow/src/apache-arrow-0.15.1/cpp/src/parquet/parquet.thrift:297] The "byte" type is a compatibility alias for "i8". Use "i8" to emphasize the signedness of this type.

And later:

 81%] Building CXX object src/parquet/CMakeFiles/parquet_static.dir/column_reader.cc.obj
C:/msys64/home/mingw-packages/mingw-w64-arrow/src/apache-arrow-0.15.1/cpp/src/parquet/arrow/writer.cc: In member function 'virtual arrow::Status parquet::arrow::FileWriterImpl::WriteColumnChunk(const std::shared_ptr<arrow::ChunkedArray>&, int64_t, int64_t)':
C:/msys64/home/mingw-packages/mingw-w64-arrow/src/apache-arrow-0.15.1/cpp/src/parquet/arrow/writer.cc:79:41: warning: 'schema_field' may be used uninitialized in this function [-Wmaybe-uninitialized]
         schema_manifest_(schema_manifest) {}
                                         ^
C:/msys64/home/mingw-packages/mingw-w64-arrow/src/apache-arrow-0.15.1/cpp/src/parquet/arrow/writer.cc:466:24: note: 'schema_field' was declared here
     const SchemaField* schema_field;

Maybe CI with `CXXFLAGS += -Werror` ?

Issue Links

• links to: GitHub Pull Request #6691