Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-6871

[Java] Enhance TransferPair related parameters check and tests

    XMLWordPrintableJSON

Details

    Description

      TransferPair related param checks in different classes have potential problems:

      i. copyValueSafe do not check from index, if from > valueCount, no error is shown.

      ii. splitAndTansfer has no indices check in classes like VarcharVector

      iii. splitAndTranser indices check in classes like UnionVector is not correct (Preconditions.checkArgument(startIndex + length <= valueCount)), should check params separately.

      iv. some assert usages should be replaced with Preconditions.

      v. should add more UT to cover corner cases.

      Attachments

        Issue Links

          Activity

            People

              tianchen92 Ji Liu
              tianchen92 Ji Liu
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 40m
                  2h 40m