[ARROW-6515] [C++] Clean type_traits.h definitions

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.16.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/22883
• Assignee: Francois Saint-Jacques
• Reporter: Ben Kietzman
• Created: 10/Sep/19 14:46
• Updated: 11/Jan/23 07:47
• Resolved: 29/Nov/19 15:55

Description

IsSignedInt takes either an array or a type as a type argument, which is surprisingly atypical for traits. Furthermore whereas is_signed_integer returns false for date and other types which are represented by but not identical to integers IsSignedInt returns true by checking only the c_type, which leads to static_assert(IsSignedInt<HalfFloatType>::value, ""). Finally the declaration of IsSignedInt is far from readable due to nested macro usage.

Issue Links

• links to: GitHub Pull Request #5885