[ARROW-6374] [Java] Refactor the code for TimeXXVectors

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Component/s: Java
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/22748
• Assignee: Liya Fan
• Reporter: Liya Fan
• Created: 28/Aug/19 10:29
• Updated: 11/Jan/23 07:46
• Resolved: 13/Feb/20 01:24

Description

This is based on the discussion in https://lists.apache.org/thread.html/836d3b87ccb6e65e9edf0f220829a29edfa394fc2cd1e0866007d86e@%3Cdev.arrow.apache.org%3E.

 

The internals of TimeXXVectors are simply IntVector or BigIntVector. There are duplicated code for setting/getting int/long.

 

We want to refactor the code by:

1. push get/set methods into the base class BaseFixedWidthVector, and make them protected.
2. The APIs in TimeXXVectors references the methods in the base class.

 

Note that this issue not just reduce redundant code, it also centralizes the logics for getting/setting int/long, making them easy to maintain and change.

 

If it looks good, later we will make other integer based vectors rely on the base class implementations. 

Issue Links

• links to: GitHub Pull Request #5213