[ARROW-6311] [Java] Make ApproxEqualsVisitor accept DiffFunction to make it more flexible

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.15.0
• Component/s: Java
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/22692
• Assignee: Ji Liu
• Reporter: Ji Liu
• Created: 21/Aug/19 17:08
• Updated: 11/Jan/23 07:46
• Resolved: 23/Aug/19 16:40

Description

Currently ApproxEqualsVisitor will accept a epsilon for both float and double compare, and the difference calculation is always Math.abs(f1-f2)

For some cases like Validator it is not very suitable as:

i. it has different epsilon values for float/double

ii. it difference function is not Math.abs(f1-f2)

 

To resolve these, make this visitor accept both float/double epsilons and diff functions.

Issue Links

• links to: GitHub Pull Request #5155