Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-6311

[Java] Make ApproxEqualsVisitor accept DiffFunction to make it more flexible

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.15.0
    • Java

    Description

      Currently ApproxEqualsVisitor will accept a epsilon for both float and double compare, and the difference calculation is always Math.abs(f1-f2)

      For some cases like Validator it is not very suitable as:

      i. it has different epsilon values for float/double

      ii. it difference function is not Math.abs(f1-f2)

       

      To resolve these, make this visitor accept both float/double epsilons and diff functions.

      Attachments

        Issue Links

          Activity

            People

              tianchen92 Ji Liu
              tianchen92 Ji Liu
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m

                  Slack

                    Issue deployment