[ARROW-6073] [C++] Decimal128Builder is not reset in Finish()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.14.1
• Fix Version/s: 0.15.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/22474
• Assignee: Kenneth Jung
• Reporter: Kenneth Jung
• Created: 30/Jul/19 19:42
• Updated: 11/Jan/23 07:44
• Resolved: 31/Jul/19 00:54

Description

Repro:

decimal128-builder_test.cc

TEST(ArrowDecimal128BuilderTest, TestResetAfterFinish) {
  auto type = std::make_shared<::arrow::Decimal128Type>(4, 4);
  auto builder = std::make_shared<::arrow::Decimal128Builder>(type);

  std::shared_ptr<::arrow::Array> out;
  ASSERT_OK(builder->Append("1"));
  ASSERT_OK(builder->Finish(&out));

  ASSERT_OK(builder->Append("2"));
  ASSERT_OK(builder->Finish(&out));
  ASSERT_EQ(out->length(), 1);
}

Output:

  Expected equality of these values:
    out->length()
    Which is: 2
    1

Issue Links

• links to: GitHub Pull Request #4970