Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-5991

[C++] Does DictionaryBuilder<T> need to be a subclass of ArrayBuilder?

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: C++
    • Labels:
      None

      Description

      I note that DictionaryBuilder<T> is book-keeping properties both in values_builder_ as well as itself, such as length_ and null_count_.

      There are two possibilities:

      • DictionaryBuilder need not be a subclass of ArrayBuilder
      • A common abstract base for builders could be defined to allow properties like length_ to be forwarded by virtual overrides

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              wesmckinn Wes McKinney
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: