Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-5549

[C++][Docs] Summarize function argument type guidelines in developers/cpp.rst

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: C++
    • Labels:
      None

      Description

      We have a number of spoken and unspoken guidelines around argument passing – some of them are codified in the Google style guide while others (e.g. use of smart pointers as function arguments) are applied via convention and enforced in code reviews.

      I propose to add a section to make each case explicit so that our code can become more hygienic and our code reviews less intense

        Attachments

          Activity

            People

            • Assignee:
              wesm Wes McKinney
              Reporter:
              wesm Wes McKinney
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: