Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
Description
The current implementation uses `std::vector` and `std::string` with unbounded size. The refactor would take a memory pool in the constructor for buffer management and would get rid of vectors. This will have the side effect of propagating Status to some calls (notably insert due to Upsize failing to resize).
- MemoTable constructor needs to take a MemoryPool in input
- GetOrInsert must return Status/Result<int32_t>
- MemoTable should use a TypeBufferBuilder instead of std::vector<Payload>
- BinaryMemoTable should use a BinaryBuilder instead of (std::vector<int32_t>, std::string) pair.
Attachments
Issue Links
- links to