[ARROW-5146] [Dev] Merge script imposes directory name

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Developer Tools
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/21627
• Assignee: Antoine Pitrou
• Reporter: Antoine Pitrou
• Created: 09/Apr/19 09:48
• Updated: 11/Jan/23 07:38
• Resolved: 10/Apr/19 12:02

Description

The merge script currently fails with a cryptic message if the parent directory isn't named "arrow":

$ ./dev/merge_arrow_pr.py 
ARROW_HOME = /home/antoine/arrow/dev
PROJECT_NAME = dev
Which pull request would you like to merge? (e.g. 34): 4113
url = 'https://api.github.com/repos/apache/dev/pulls/4113'
{'documentation_url': 'https://developer.github.com/v3/pulls/#get-a-single-pull-request',
 'message': 'Not Found'}
Traceback (most recent call last):
  File "./dev/merge_arrow_pr.py", line 462, in <module>
    cli()
  File "./dev/merge_arrow_pr.py", line 417, in cli
    pr = PullRequest(cmd, github_api, git_remote, jira_con, pr_num)
  File "./dev/merge_arrow_pr.py", line 252, in __init__
    self.url = self._pr_data["url"]
KeyError: 'url'

PROJECT_HOME is inferred from the current directory name, though it should almost always be "arrow".

Issue Links

• links to: GitHub Pull Request #4129