[ARROW-5081] [C++] Consistently use PATH_SUFFIXES in CMake config

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/16053
• Assignee: David Li
• Reporter: David Li
• Created: 01/Apr/19 12:52
• Updated: 11/Jan/23 07:38
• Resolved: 04/Apr/19 19:51

Description

In trying to set up a build using system libraries installed to non-default paths, CMake doesn't consistently search user-specified paths for libraries.

For instance, FindDoubleConversion.cmake will look only at ${DoubleConversion_ROOT}/libdoubleconversion.so for the shared library, making it impossible to have a directory setup like doubleconversion/lib/.so + doubleconversion/include. Other Find.cmake files set PATH_SUFFIXES to also search the lib/ subdirectory; we should do this everywhere.

Additionally, it seems the various Find*.cmake files set PATH_SUFFIXES inconsistently. Some hardcode their own list, others use CMAKE_LIBRARY_ARCHITECTURE.

Issue Links

• links to: GitHub Pull Request #4092