Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-4930

[Python] Remove LIBDIR assumptions in Python build

    XMLWordPrintableJSON

    Details

      Description

      This is in reference to (4) in this mailing list discussion.

      Certain sections of setup.py assume a specific location of the C++ libraries. Removing this hard assumption will simplify PyArrow builds significantly. As far as I could tell these assumptions are made in the build_ext._run_cmake() method (wherever bundling of C++ libraries are handled).

      1. The first occurrence is before invoking cmake (see line 237).
      2. The second occurrence is when the C++ libraries are moved from their build directory to the Python tree (see line 347). The actual implementation is in the function _move_shared_libs_unix(..) (see line 468).

      Hope this helps.

        Attachments

        1. FindArrow.cmake.patch
          0.6 kB
          Suvayu Ali
        2. FindParquet.cmake.patch
          0.9 kB
          Suvayu Ali

          Activity

            People

            • Assignee:
              kou Kouhei Sutou
              Reporter:
              suvayu Suvayu Ali
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 7.5h
                7.5h