Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-4571

[Format] Tensor.fbs file has multiple root_type declarations

    XMLWordPrintableJSON

    Details

      Description

      Looking at the flatbuffers doc, it appears there should only be one `root_type` declaration in an fbs file:

      The last part of the schema is the root_type. The root type declares what will be the root table for the serialized data. In our case, the root type is our Monster table.

      However, the Tensor.fbs file has multiple `root_type` declarations:

      https://github.com/apache/arrow/blob/69d595ae4c61902b3f2778e536fca6675350c88c/format/Tensor.fbs#L53

      https://github.com/apache/arrow/blob/69d595ae4c61902b3f2778e536fca6675350c88c/format/Tensor.fbs#L146

       

      See the discussion here: https://github.com/apache/arrow/pull/2546#discussion_r256549256

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mrkn Kenta Murata
                Reporter:
                eerhardt Eric Erhardt
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m