Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-4520

[C++] DCHECK custom messages are unreachable in release

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: C++

      Description

      For release builds, DCHECK( x ) << y << z; currently expands to

      ((void)(x)); 
      while (false) ::arrow::util::ArrowLogBase() << y << z;
      

      This is unreachable which is an error using clang-7

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bkietz Benjamin Kietzman
                Reporter:
                bkietz Benjamin Kietzman
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 9h 20m
                  9h 20m