Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-4250

[C++][Gandiva] Use approximate comparisons for floating point numbers in gandiva-projector-test

    XMLWordPrintableJSON

    Details

      Description

      I experienced a failure due to floating point comparison when running the release verification script for 0.12.0 RC2.

      [==========] Running 13 tests from 1 test case.
      [----------] Global test environment set-up.
      [----------] 13 tests from TestProjector
      [ RUN      ] TestProjector.TestProjectCache
      [       OK ] TestProjector.TestProjectCache (584 ms)
      [ RUN      ] TestProjector.TestProjectCacheFieldNames
      [       OK ] TestProjector.TestProjectCacheFieldNames (319 ms)
      [ RUN      ] TestProjector.TestProjectCacheDouble
      [       OK ] TestProjector.TestProjectCacheDouble (304 ms)
      [ RUN      ] TestProjector.TestProjectCacheFloat
      [       OK ] TestProjector.TestProjectCacheFloat (305 ms)
      [ RUN      ] TestProjector.TestIntSumSub
      [       OK ] TestProjector.TestIntSumSub (200 ms)
      [ RUN      ] TestProjector.TestAllIntTypes
      [       OK ] TestProjector.TestAllIntTypes (1945 ms)
      [ RUN      ] TestProjector.TestExtendedMath
      /tmp/arrow-0.12.0.a2ADf/apache-arrow-0.12.0/cpp/src/gandiva/tests/projector_test.cc:358: Failure
      Value of: (expected_cbrt)->Equals(outputs.at(0))
        Actual: false
      Expected: true
      expected array: [
        2.51984,
        2.15443,
        -2.41014,
        2.02469
      ] actual array: [
        2.51984,
        2.15443,
        -2.41014,
        2.02469
      ]
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bkietz Ben Kietzman
                Reporter:
                wesm Wes McKinney
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h