[ARROW-3923] [Java] JDBC-to-Arrow Conversion: Unnecessary Calendar Requirement

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Java
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/20534
• Assignee: Michael Pigott
• Reporter: Michael Pigott
• Created: 01/Dec/18 18:27
• Updated: 11/Jan/23 07:30
• Resolved: 05/Feb/19 09:22

Description

While I was going through the JDBC Adapter source code, I noticed a Calendar was required to create the Arrow Schema (for any Timestamp fields), and also needed for converting a JDBC ResultSet to an ArrowVector (for Date, Time, and Timestamp fields).

However, Arrow Timestamps do not require a time zone, and none of the JDBC getters for Date, Time, and Timestamp require a Calendar.

I am proposing a change to make the Schema creator and ResultSet converter support null Calendars. If a Calendar is available, it will be used, and if not, it will not be used.

The existing SureFire plugin configuration uses a UTC calendar for the database, which is the default Calendar in the existing code.  Likewise, no changes to the unit tests are required to provide adequate coverage for the change.

Issue Links

• links to: GitHub Pull Request #3066