Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-3906

[C++] Break builder.cc into multiple compilation units

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.11.1
    • 0.12.0
    • C++

    Description

      To improve readability I suggest splitting builder.cc into independent compilation units. Concrete builder classes are generally independent of each other. The only concern is whether inlining some of the base class implementations is important for performance.

      This would also make incremental compilation faster when changing one of the concrete classes.

      Attachments

        Issue Links

          Activity

            People

              apitrou Antoine Pitrou
              apitrou Antoine Pitrou
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h