[ARROW-3242] [C++] Use coarser-grained dispatch to SIMD hash functions

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/19584
• Assignee: Wes McKinney
• Reporter: Wes McKinney
• Created: 16/Sep/18 14:57
• Updated: 11/Jan/23 07:26
• Resolved: 17/Sep/18 16:09

Description

The way that we dispatch to SSE4 hash functions is a remnant from the Impala codebase, which checks CpuInfo on every iteration in debug builds:

https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/hash-util.h#L43

However, the static model_name_ member is causing some non-determinism related to static member lifetime as reported in ARROW-3241.

I'm proposing to refactor CpuInfo into a singleton pattern and handle SIMD vs non-SIMD dispatch at a higher level rather than at the lowest level like it is now. This should hopefully make the issue in ARROW-3241 go away

Issue Links

• links to: GitHub Pull Request #2571