Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-3242

[C++] Use coarser-grained dispatch to SIMD hash functions

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: C++

      Description

      The way that we dispatch to SSE4 hash functions is a remnant from the Impala codebase, which checks CpuInfo on every iteration in debug builds:

      https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/hash-util.h#L43

      However, the static model_name_ member is causing some non-determinism related to static member lifetime as reported in ARROW-3241.

      I'm proposing to refactor CpuInfo into a singleton pattern and handle SIMD vs non-SIMD dispatch at a higher level rather than at the lowest level like it is now. This should hopefully make the issue in ARROW-3241 go away

        Attachments

          Activity

            People

            • Assignee:
              wesm Wes McKinney
              Reporter:
              wesm Wes McKinney

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m

                  Issue deployment