[ARROW-3157] [C++] Improve buffer creation for typed data

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11.0
• Component/s: C++
• Labels: pull-request-available usability
• External issue URL: https://github.com/apache/arrow/issues/19505
• Assignee: Wes McKinney
• Reporter: Philipp Moritz
• Created: 01/Sep/18 22:07
• Updated: 11/Jan/23 07:25
• Resolved: 17/Sep/18 16:13

Description

While looking into https://github.com/apache/arrow/pull/2481, I noticed this pattern:

const uint8_t* bytes_array = reinterpret_cast<const uint8_t*>(input);
auto buffer = std::make_shared<Buffer>(bytes_array, sizeof(float)*input_length);

It's not the end of the world but seems a little verbose to me. It would be great to have something like this:

auto buffer = MakeBuffer<float>(input, input_length);

I couldn't find it, does it already exist somewhere? Any thoughts on the API? Potentially specializations to make a buffer out of a std::vector<T> would also be helpful.

 

Issue Links

• links to: GitHub Pull Request #2566