Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-2730

[C++] Set up CMAKE_C_FLAGS more thoughtfully instead of using CMAKE_CXX_FLAGS

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: C++
    • Labels:
      None

      Description

      See discussion on GitHub for ARROW-2676. We are setting CMAKE_C_FLAGS to the value of CMAKE_CXX_FLAGS, which is rather heavy-handed. Most of the stuff we are putting in the CXX_FLAGS is C++-specific related to warning suppressions, etc. The number of C-specific flags we need should be much smaller, probably just the optimization level, position-independent code setting, -fno-strict-aliasing, and some other standard stuff

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              wesmckinn Wes McKinney
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: