Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-2508

[Python] pytest API changes make tests fail

    Details

      Description

      Seems like there is a new pytest on pypy, it produces the following failures:

      ```
      =================================== FAILURES ===================================
      __ TestConvertDateTimeLikeTypes.test_pandas_datetime_to_date64_failures[None] __
       
      self = <pyarrow.tests.test_convert_pandas.TestConvertDateTimeLikeTypes object at 0x112dd6a90>
      mask = None
       
      @pytest.mark.parametrize('mask', [
      None,
      np.ones(3),
      np.array([True, False, False])
      ])
      def test_pandas_datetime_to_date64_failures(self, mask):
      s = pd.to_datetime([
      '2018-05-10T10:24:01',
      '2018-05-11T10:24:01',
      '2018-05-12T10:24:01',
      ])
       
      expected_msg = 'Timestamp value had non-zero intraday milliseconds'
      > with pytest.raises(pa.ArrowInvalid, msg=expected_msg):
      E TypeError: Unexpected keyword arguments passed to pytest.raises: msg
       
      pyarrow-test-3.6/lib/python3.6/site-packages/pyarrow/tests/test_convert_pandas.py:862: TypeError
      _ TestConvertDateTimeLikeTypes.test_pandas_datetime_to_date64_failures[mask1] __
       
      self = <pyarrow.tests.test_convert_pandas.TestConvertDateTimeLikeTypes object at 0x113213160>
      mask = array([ 1., 1., 1.])
       
      @pytest.mark.parametrize('mask', [
      None,
      np.ones(3),
      np.array([True, False, False])
      ])
      def test_pandas_datetime_to_date64_failures(self, mask):
      s = pd.to_datetime([
      '2018-05-10T10:24:01',
      '2018-05-11T10:24:01',
      '2018-05-12T10:24:01',
      ])
       
      expected_msg = 'Timestamp value had non-zero intraday milliseconds'
      > with pytest.raises(pa.ArrowInvalid, msg=expected_msg):
      E TypeError: Unexpected keyword arguments passed to pytest.raises: msg
       
      pyarrow-test-3.6/lib/python3.6/site-packages/pyarrow/tests/test_convert_pandas.py:862: TypeError
      _ TestConvertDateTimeLikeTypes.test_pandas_datetime_to_date64_failures[mask2] __
       
      self = <pyarrow.tests.test_convert_pandas.TestConvertDateTimeLikeTypes object at 0x112ed4c88>
      mask = array([ True, False, False], dtype=bool)
       
      @pytest.mark.parametrize('mask', [
      None,
      np.ones(3),
      np.array([True, False, False])
      ])
      def test_pandas_datetime_to_date64_failures(self, mask):
      s = pd.to_datetime([
      '2018-05-10T10:24:01',
      '2018-05-11T10:24:01',
      '2018-05-12T10:24:01',
      ])
       
      expected_msg = 'Timestamp value had non-zero intraday milliseconds'
      > with pytest.raises(pa.ArrowInvalid, msg=expected_msg):
      E TypeError: Unexpected keyword arguments passed to pytest.raises: msg
       
      pyarrow-test-3.6/lib/python3.6/site-packages/pyarrow/tests/test_convert_pandas.py:862: TypeError
      =========================== short test summary info ============================
      ```

      I think we can just change msg to message and it should work again.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                pcmoritz Philipp Moritz
                Reporter:
                pcmoritz Philipp Moritz
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h