[ARROW-2442] [C++] Disambiguate Builder::Append overloads

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.0
• Fix Version/s: 0.10.0
• Component/s: C++
• Labels: beginner pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/18575
• Assignee: Antoine Pitrou
• Reporter: Antoine Pitrou
• Created: 10/Apr/18 13:28
• Updated: 11/Jan/23 07:21
• Resolved: 18/Apr/18 11:00

Description

See discussion in https://github.com/apache/arrow/pull/1852#discussion_r179919627

There are various Append() overloads in Builder and subclasses, some of which append one value, some of which append multiple values at once.

The API might be clearer and less error-prone if multiple-append variants were named differently, for example AppendValues(). Especially with the pointer-taking variants, it's probably easy to call the wrong overload by mistake.

The existing methods would have to go through a deprecation cycle.

Issue Links

• links to: GitHub Pull Request #1900