Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-2386

[Plasma] Change PlasmaClient::Create API

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: C++ - Plasma
    • Labels:
      None

      Description

      Now that the Get API is refactored in https://github.com/apache/arrow/pull/1807, we should do the same for the Create API.

      Proposal:

      Have a MutablePlasmaBuffer class, which is returned by Create

      Status Create(int64_t data_size, int64_t metadata_size, std::shared_ptr<MutablePlasmaBuffer>* buffer)
      

      This allocates the data in shared memory, but does not associate it with the object id yet. This way we get get rid of the Abort() call.

      Move the Seal() method into the MutablePlasmaBuffer and let it return the object ID.

       

      This is very similar to what [~pitrou] suggested here: https://github.com/apache/arrow/pull/1807

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                pcmoritz Philipp Moritz
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: