Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-2167

[C++] Building Orc extensions fails with the default BUILD_WARNING_LEVEL=Production

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0
    • Component/s: C++
    • Labels:
      None

      Description

      Building orc_ep fails because there are a bunch of upstream warnings like not providing override on virtual destructor subclasses, and using 0 as the nullptr constant and the default BUILD_WARNING_LEVEL is Production which includes -Wall (all warnings as errors).

      I see that there are different possible options for BUILD_WARNING_LEVEL so it's possible for developers to deal with this issue.

      It seems easier to let EPs build with whatever the default warning level is for the project rather than force our defaults on those projects.

      Generally speaking, are we using our own CXX_FLAGS for EPs other than Orc?

        Attachments

          Activity

            People

            • Assignee:
              wesmckinn Wes McKinney
              Reporter:
              cpcloud Phillip Cloud
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: