[ARROW-2138] [C++] Have FatalLog abort instead of exiting

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.9.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/18106
• Assignee: Antoine Pitrou
• Reporter: Antoine Pitrou
• Created: 12/Feb/18 16:06
• Updated: 11/Jan/23 07:19
• Resolved: 12/Feb/18 21:09

Description

Not sure this is desirable, since util/logging.h was taken from glog, but the various debug checks current std::exit(1) on failure. This is a clean exit (though with an error code) and therefore doesn't trigger the usual debugging tools such as gdb or Python's faulthandler. By replacing it with something like std::abort() the exit would be recognized as a process crash.

 

Thoughts?

Issue Links

• links to: GitHub Pull Request #1595