Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-2138

[C++] Have FatalLog abort instead of exiting

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: C++

      Description

      Not sure this is desirable, since util/logging.h was taken from glog, but the various debug checks current std::exit(1) on failure. This is a clean exit (though with an error code) and therefore doesn't trigger the usual debugging tools such as gdb or Python's faulthandler. By replacing it with something like std::abort() the exit would be recognized as a process crash.

       

      Thoughts?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                pitrou Antoine Pitrou
                Reporter:
                pitrou Antoine Pitrou
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: