[ARROW-1904] [C++] Deprecate PrimitiveArray::raw_values

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.8.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/17896
• Assignee: Wes McKinney
• Reporter: Wes McKinney
• Created: 07/Dec/17 20:44
• Updated: 11/Jan/23 07:17
• Resolved: 11/Dec/17 15:42

Description

I ran into an odd issue where, even though I was casting to arrow::PrimitiveArray, it picked up the raw_values method from a subclass of PrimitiveArray (which includes a slice offset)

(gdb) p reinterpret_cast<const int64_t*>(reinterpret_cast<const PrimitiveArray&>(arr).raw_values())[0]
$9 = 25
(gdb) p reinterpret_cast<const int64_t*>(reinterpret_cast<const PrimitiveArray&>(arr).raw_values_)[0]
$10 = 10
(gdb) p arr.offset()
$11 = 15

I think the raw_values method in PrimitiveArray should be deprecated and removed, since it is dangerous to use as it does not include a slice offset, if any

Issue Links

• links to: GitHub Pull Request #1409