[ARROW-18126] [Python] Remove ARROW_BUILD_DIR in building pyarrow C++

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 11.0.0
• Component/s: Python
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/33323
• Assignee: Alenka Frim
• Reporter: Joris Van den Bossche
• Created: 21/Oct/22 11:36
• Updated: 11/Jan/23 11:58
• Resolved: 25/Oct/22 20:41

Description

When building pyarrow, I see the following warning:

CMake Warning:
  Manually-specified variables were not used by the project:

    ARROW_BUILD_DIR

While we have a note in our docs (https://arrow.apache.org/docs/dev/developers/python.html#build-and-test) that says:

If you used a different directory name for building Arrow C++ (by default it is named “build”), then you should also set the environment variable ARROW_BUILD_DIR='name_of_build_dir'. This way PyArrow can find the Arrow C++ built files.

I see in the setup.py code that we check for this env variable and pass it to CMake, but it's not actually used in any of the CMakeLists.txt files for pyarrow.

This might have been accidentally changed in one of the recent cmake refactors? (cc kou alenka)

Issue Links

• links to: GitHub Pull Request #14498