[ARROW-17230] [C++] Fix minor bugs in Substrait to ExecPlan conversion

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 10.0.0
• Component/s: C++
• Labels: pull-request-available query-engine substrait
• External issue URL: https://github.com/apache/arrow/issues/32517
• Assignee: David Li
• Reporter: David Li
• Created: 27/Jul/22 19:22
• Updated: 11/Jan/23 11:49
• Resolved: 28/Jul/22 05:13

Description

• The return type of DeserializePlan is wrong: it should be shared_ptr<ExecPlan>, else we get a use-after-free.
• Errors are ignored where they shouldn't be: you can get a half-constructed plan instead of an error.
• A stateful callback is called twice, leading to invalid options being passed.

Issue Links

• links to: GitHub Pull Request #13728