[ARROW-16987] [C++] Refactor Substrait ToProto/FromProto to visitor pattern

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: C++
• Labels: substrait
• External issue URL: https://github.com/apache/arrow/issues/32301
• Assignee: Unassigned
• Reporter: Jeroen van Straten
• Created: 06/Jul/22 12:46
• Updated: 11/Jan/23 11:47

Description

Currently, the conversion between Acero and Substrait plans is done ad hoc using various overloads of the ToProto and FromProto functions. Code quality may benefit from refactoring this to a visitor pattern, to make it more easy to track state (ExtensionSet), store conversion options, maybe make multiple implementations in the future via inheritance, etc.

It's probably better to do this sooner rather than later (if we're going to do it).