Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-16948

[C++] Benchmark Aggregates Fails To Compile After Aggregate Updates

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • None
    • 9.0.0
    • C++

    Description

      Aggregate Benchmark fails with the following error. 

      vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:342:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:357:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:372:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:386:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:400:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:414:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:432:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {int_key, str_key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:450:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {int_key, str_key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:468:48: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_sum", NULLPTR}}, {summand}, {int_key, str_key});
                                                     ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:481:52: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_min_max", NULLPTR}}, {input}, {int_key});
                                                         ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:491:52: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_min_max", NULLPTR}}, {input}, {int_key});
                                                         ^
      /Users/vibhatha/github/fork/arrow/cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:501:52: error: missing field 'target' initializer [-Werror,-Wmissing-field-initializers]
        BenchmarkGroupBy(state, {{"hash_min_max", NULLPTR}}, {input}, {int_key});
      

       

      This was caused after adding the changes for Aggregates in https://issues.apache.org/jira/browse/ARROW-16549

      This wasn't caught since it was not included during the build on Mac M1. Possibly there is no CI covering this on Mac M1. 

      Attachments

        Issue Links

          Activity

            People

              vibhatha Vibhatha Lakmal Abeykoon
              vibhatha Vibhatha Lakmal Abeykoon
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m