[ARROW-16585] [C++] CMake and pkg-config files are broken when CMAKE_INSTALL_{BIN,INCLUDE,LIB}DIR is absolute

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/31942

Language

CMake

• Assignee: Kouhei Sutou
• Reporter: Alexander Shpilkin
• Created: 16/May/22 07:34
• Updated: 11/Jan/23 11:45
• Resolved: 19/May/22 01:56

Description

As per title: cpp/src/gandiva/gandiva.pc.in, cpp/src/parquet/parquet.pc.in, cpp/src/plasma/plasma.pc.in, and cpp/src/skyhook/skyhook.pc.in have

prefix=@CMAKE_INSTALL_PREFIX@
libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@
includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@ # not in plasma.pc.in

while cpp/src/plasma/PlasmaConfig.cmake.in has

set(PLASMA_STORE_SERVER "@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_BINDIR@/plasma-store-server@CMAKE_EXECUTABLE_SUFFIX@")

and so they can’t handle absolute paths in CMAKE_INSTALL_{BIN,INCLUDE,LIB}DIR. This leads to broken .pc files on NixOS in particular.

See “Concatenating paths when building pkg-config files” for a thorough discussion of the problem and a suggested fix, or KDE’s extra-cmake-modules for a simpler approach.

Issue Links

• links to: GitHub Pull Request #13182