[ARROW-16424] [C++] Update uri_path parsing in FromProto

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 10.0.0
• Component/s: C++
• Labels: pull-request-available substrait
• External issue URL: https://github.com/apache/arrow/issues/31799
• Assignee: Aldrin Montana
• Reporter: Ariana Villegas
• Created: 29/Apr/22 22:54
• Updated: 11/Jan/23 11:44
• Resolved: 12/Oct/22 14:26

Description

FromProto function in arrow/engine/substrait/relation_internal.cc parse uri_path with string_view utilities. However this should be done with Uri class from arrow/util/uri.h.

else if (util::string_view{path}.ends_with(".arrow")) {
  format = std::make_shared<dataset::IpcFileFormat>();
} else if (util::string_view{path}.ends_with(".feather")) {
  format = std::make_shared<dataset::IpcFileFormat>();

Issue Links

• causes: ARROW-18041 [Python] Sustrait-related test failure in wheel tests
• is duplicated by: ARROW-16392 [C++] Substrait consumer cannot handle file URIs that contain a Windows drive letter
• links to: GitHub Pull Request #13390
• links to: GitHub Pull Request #14071